{"id":"GHSA-ghmh-jhmj-wcmf","aliases":["GO-2026-5399"],"status":"published","title":"nebula-mesh's stores enrollment tokens unhashed in SQLite","description":"`internal/store/sqlite.go:1177,1192,1221,1245` — the `enrollment_tokens.token` column holds the raw UUID token. `ConsumeToken` does `WHERE token = ?` against the raw string. Compare with `operator_api_keys.key_hash`, which is SHA-256 hex (constructed in `internal/api/middleware.go:51-53`).\n\n## Affected\nAll released versions up to v0.3.0.\n\n## Threat model\nRead access to `nebula-mgmt.db`: backup, snapshot, file-system access, future SQL-injection sink. The principle of defense-in-depth: API keys are hashed at rest; enrollment tokens — which grant the same lifecycle authority over a host's identity — are not.\n\nAn attacker who reads the DB before a legitimate agent enrolls can consume the single-use token first, mint a cert against their own keypair, and take the agent's intended Nebula identity.\n\n## Suggested fix\n1. Schema migration: rename `enrollment_tokens.token` → `token_hash` (or add the new column and drop the old after backfill of pending rows).\n2. Store SHA-256 of token on create:\n   ```go\n   sum := sha256.Sum256([]byte(token))\n   row.TokenHash = hex.EncodeToString(sum[:])\n   ```\n3. `ConsumeToken` accepts the raw token, hashes once, looks up by hash, atomically marks consumed.\n\nSide bonus: take this opportunity to switch the token format from `uuid.New().String()` (122 bits) to `hex.EncodeToString(crypto/rand 32 bytes)` (256 bits), matching the project's session-token and API-key conventions. UUIDs are recognisable in logs and crash dumps; opaque hex blends in.\n\nTOTP recovery codes appear to already be SHA-256 hashed at rest (`internal/web/totp.go:74-78`) — confirming that pattern is intentional elsewhere, just missed here.","severity":{"version":"4.0","score":5,"vector":"CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:L/VI:H/VA:N/SC:N/SI:N/SA:N/E:U","level":"medium","from":"ghsa"},"facts":{"in_kev":false,"known_exploited":false,"public_exploit":false,"fix_available":true},"cwes":["CWE-312"],"published":"2026-06-22T22:57:27Z","modified":"2026-06-25T23:11:47Z","fixes":[{"ecosystem":"Go","package":"github.com/juev/nebula-mesh","fixed_in":["0.3.2"],"sources":["ghsa","osv"]}],"affected":[{"source":"ghsa","ecosystem":"Go","package":"github.com/juev/nebula-mesh","ranges":[{"type":"ECOSYSTEM","events":[{"introduced":"0"},{"last_affected":"0.3.1"},{"fixed":"0.3.2"}]}]},{"source":"osv","ecosystem":"Go","package":"github.com/juev/nebula-mesh","ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"0.3.2"}]}]},{"source":"osv","ecosystem":"Go","package":"github.com/juev/nebula-mesh","ranges":[{"type":"SEMVER","events":[{"introduced":"0"},{"fixed":"0.3.2"}]}]}],"references":[{"url":"https://github.com/juev/nebula-mesh/security/advisories/GHSA-ghmh-jhmj-wcmf","tags":["web","advisory"]},{"url":"https://github.com/advisories/GHSA-ghmh-jhmj-wcmf"},{"url":"https://github.com/juev/nebula-mesh","tags":["package"]}],"sources":{"ghsa":[{"id":"GHSA-ghmh-jhmj-wcmf","title":"nebula-mesh's stores enrollment tokens unhashed in SQLite","description":"`internal/store/sqlite.go:1177,1192,1221,1245` — the `enrollment_tokens.token` column holds the raw UUID token. `ConsumeToken` does `WHERE token = ?` against the raw string. Compare with `operator_api_keys.key_hash`, which is SHA-256 hex (constructed in `internal/api/middleware.go:51-53`).\n\n## Affected\nAll released versions up to v0.3.0.\n\n## Threat model\nRead access to `nebula-mgmt.db`: backup, snapshot, file-system access, future SQL-injection sink. The principle of defense-in-depth: API keys are hashed at rest; enrollment tokens — which grant the same lifecycle authority over a host's identity — are not.\n\nAn attacker who reads the DB before a legitimate agent enrolls can consume the single-use token first, mint a cert against their own keypair, and take the agent's intended Nebula identity.\n\n## Suggested fix\n1. Schema migration: rename `enrollment_tokens.token` → `token_hash` (or add the new column and drop the old after backfill of pending rows).\n2. Store SHA-256 of token on create:\n   ```go\n   sum := sha256.Sum256([]byte(token))\n   row.TokenHash = hex.EncodeToString(sum[:])\n   ```\n3. `ConsumeToken` accepts the raw token, hashes once, looks up by hash, atomically marks consumed.\n\nSide bonus: take this opportunity to switch the token format from `uuid.New().String()` (122 bits) to `hex.EncodeToString(crypto/rand 32 bytes)` (256 bits), matching the project's session-token and API-key conventions. UUIDs are recognisable in logs and crash dumps; opaque hex blends in.\n\nTOTP recovery codes appear to already be SHA-256 hashed at rest (`internal/web/totp.go:74-78`) — confirming that pattern is intentional elsewhere, just missed here.","status":"published","published":"2026-06-22T22:57:27Z","modified":"2026-06-22T22:57:27Z","cvss":[{"version":"4.0","score":5,"vector":"CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:L/VI:H/VA:N/SC:N/SI:N/SA:N/E:U","level":"medium"}],"cwes":["CWE-312"],"updated_at":"2026-11-02T14:40:32.744157Z"}],"osv":[{"id":"GHSA-ghmh-jhmj-wcmf","title":"nebula-mesh's stores enrollment tokens unhashed in SQLite","description":"`internal/store/sqlite.go:1177,1192,1221,1245` — the `enrollment_tokens.token` column holds the raw UUID token. `ConsumeToken` does `WHERE token = ?` against the raw string. Compare with `operator_api_keys.key_hash`, which is SHA-256 hex (constructed in `internal/api/middleware.go:51-53`).\n\n## Affected\nAll released versions up to v0.3.0.\n\n## Threat model\nRead access to `nebula-mgmt.db`: backup, snapshot, file-system access, future SQL-injection sink. The principle of defense-in-depth: API keys are hashed at rest; enrollment tokens — which grant the same lifecycle authority over a host's identity — are not.\n\nAn attacker who reads the DB before a legitimate agent enrolls can consume the single-use token first, mint a cert against their own keypair, and take the agent's intended Nebula identity.\n\n## Suggested fix\n1. Schema migration: rename `enrollment_tokens.token` → `token_hash` (or add the new column and drop the old after backfill of pending rows).\n2. Store SHA-256 of token on create:\n   ```go\n   sum := sha256.Sum256([]byte(token))\n   row.TokenHash = hex.EncodeToString(sum[:])\n   ```\n3. `ConsumeToken` accepts the raw token, hashes once, looks up by hash, atomically marks consumed.\n\nSide bonus: take this opportunity to switch the token format from `uuid.New().String()` (122 bits) to `hex.EncodeToString(crypto/rand 32 bytes)` (256 bits), matching the project's session-token and API-key conventions. UUIDs are recognisable in logs and crash dumps; opaque hex blends in.\n\nTOTP recovery codes appear to already be SHA-256 hashed at rest (`internal/web/totp.go:74-78`) — confirming that pattern is intentional elsewhere, just missed here.","status":"published","published":"2026-06-22T22:57:27Z","modified":"2026-06-25T23:11:47.62038288Z","cvss":[{"version":"4.0","score":5,"vector":"CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:L/VI:H/VA:N/SC:N/SI:N/SA:N/E:U","level":"medium"}],"cwes":["CWE-312"],"updated_at":"2026-11-02T15:46:47.822182Z"},{"id":"GO-2026-5399","title":"nebula-mesh's stores enrollment tokens unhashed in SQLite in github.com/juev/nebula-mesh","description":"nebula-mesh's stores enrollment tokens unhashed in SQLite in github.com/juev/nebula-mesh","status":"published","published":"2026-06-25T22:34:31Z","modified":"2026-06-25T23:00:54.657531264Z","updated_at":"2026-11-02T15:47:02.556545Z"}]}}