CVE-2020-12283

Sourcegraph before 3.15.1 has a vulnerable authentication workflow because of improper validation in the SafeRedirectURL method in cmd/frontend/auth/redirect.go, such as for the //foo//example.com substring.

Sourcegraph before 3.15.1 has a vulnerable authentication workflow because of improper validation in the SafeRedirectURL method in cmd/frontend/auth/redirect.go, such as for the //foo//example.com substring.

Sourcegraph before 3.15.1 has a vulnerable authentication workflow because of improper validation in the SafeRedirectURL method in cmd/frontend/auth/redirect.go, such as for the //foo//example.com substring.

Impact

An open redirect vulnerability that allows users to be targeted for phishing attacks has been found in Sourcegraph instances configured with OAuth, OpenID, or SAML authentication enabled. Users targeted by these phishing attacks could have their authentication tokens silently harvested by an attacker.

Specific Go Packages Affected

github.com/sourcegraph/sourcegraph/cmd/frontend/auth

Resolution

Sourcegraph v3.14.4 and v3.15.1 have been released which resolve the vulnerability. (associated change)

Workarounds

Disabling OAuth, OpenID and/or SAML sign-in options until upgraded to the patched versions will secure Sourcegraph / workaround the issue.

Timeline

• Apr 23, 8 AM PST: GitHub Security Lab reported the issue to Sourcegraph.
• Apr 23, 11 PM PST: A Sourcegraph engineer proposed a resolution for the vulnerability. https://github.com/sourcegraph/sourcegraph/pull/10167
• Apr 24, 3 AM PST: The proposed resolution was reviewed, approved, and merged.
• Apr 28, 2 PM PST: Patch releases for 3.14.4 and 3.15.1 were published.
• Apr 29, 10 PM PST: Mitre publicly disclosed CVE-2020-12283.
• Apr 30, 11 AM PST: Sourcegraph issued a GitHub security advisory and notified all affected users.

References

• Mitre: CVE-2020-12283
• GitHub Security Lab: GHSL-2020-085
• detectify's blog post on open redirect vulnerabilities

For more information

If you have any questions or comments about this advisory, please contact us at [email protected] and include CVE-2020-12283 in the title.

Impact

An open redirect vulnerability that allows users to be targeted for phishing attacks has been found in Sourcegraph instances configured with OAuth, OpenID, or SAML authentication enabled. Users targeted by these phishing attacks could have their authentication tokens silently harvested by an attacker.

Specific Go Packages Affected

github.com/sourcegraph/sourcegraph/cmd/frontend/auth

Resolution

Sourcegraph v3.14.4 and v3.15.1 have been released which resolve the vulnerability. (associated change)

Workarounds

Disabling OAuth, OpenID and/or SAML sign-in options until upgraded to the patched versions will secure Sourcegraph / workaround the issue.

Timeline

• Apr 23, 8 AM PST: GitHub Security Lab reported the issue to Sourcegraph.
• Apr 23, 11 PM PST: A Sourcegraph engineer proposed a resolution for the vulnerability. https://github.com/sourcegraph/sourcegraph/pull/10167
• Apr 24, 3 AM PST: The proposed resolution was reviewed, approved, and merged.
• Apr 28, 2 PM PST: Patch releases for 3.14.4 and 3.15.1 were published.
• Apr 29, 10 PM PST: Mitre publicly disclosed CVE-2020-12283.
• Apr 30, 11 AM PST: Sourcegraph issued a GitHub security advisory and notified all affected users.

References

• Mitre: CVE-2020-12283
• GitHub Security Lab: GHSL-2020-085
• detectify's blog post on open redirect vulnerabilities

For more information

If you have any questions or comments about this advisory, please contact us at [email protected] and include CVE-2020-12283 in the title.